Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #575

Merged
merged 7 commits into from
May 11, 2020
Merged

Add tests #575

merged 7 commits into from
May 11, 2020

Conversation

bloodyowl
Copy link
Contributor

Copy link
Contributor

@rickyvetter rickyvetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! Can we see the GH actions/tests run on this PR? Or does it need to land first?

Only question/concern I have is BS version bump. We will bump to 7.3 soon regardless but it's a very new release and I'd like to give a bit of time for organic upgrade before pushing people.

package.json Outdated Show resolved Hide resolved
@bloodyowl
Copy link
Contributor Author

@rickyvetter I think it needs to land on master (or at least in the correct repository) in order for the action to run.

The BS version bump is so that reason-test-framework can have simpler bindings (using unit instead of an undefined value for function return values, which is significant in Jest). I'll release a version tomorrow that adds that back so that the bump isn't necessary.

@bloodyowl
Copy link
Contributor Author

@rickyvetter Here's how it looks on the reason-test-framework repo:

Screenshot 2020-05-09 at 09 43 37

Screenshot 2020-05-09 at 09 43 55

Screenshot 2020-05-09 at 09 43 58

@bloodyowl
Copy link
Contributor Author

bloodyowl commented May 9, 2020

I'll add a few more tests later today:

  • React.null
  • React.string
  • React.int
  • React.float
  • React.array
  • React.cloneElement
  • Ref
  • Children
  • Context
  • useReducerWithMapState
  • useLayoutEffect
  • Basic event support

@rickyvetter rickyvetter merged commit f0a78d1 into reasonml:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants