-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests #575
Add tests #575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! Can we see the GH actions/tests run on this PR? Or does it need to land first?
Only question/concern I have is BS version bump. We will bump to 7.3 soon regardless but it's a very new release and I'd like to give a bit of time for organic upgrade before pushing people.
@rickyvetter I think it needs to land on master (or at least in the correct repository) in order for the action to run. The BS version bump is so that reason-test-framework can have simpler bindings (using unit instead of an undefined value for function return values, which is significant in Jest). I'll release a version tomorrow that adds that back so that the bump isn't necessary. |
@rickyvetter Here's how it looks on the reason-test-framework repo: |
I'll add a few more tests later today:
|
#563