Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstrings #1446

Merged
merged 74 commits into from
Jun 16, 2021
Merged

Add docstrings #1446

merged 74 commits into from
Jun 16, 2021

Conversation

miguelgfierro
Copy link
Collaborator

Description

Related Issues

#1441

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

YanZhangADS and others added 30 commits May 26, 2021 17:38
* review 📝 in common

* wip

* deprec

* fix 📝

Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
* 🐛 in installation process and in test execution

* make sure we are using the package when running the test 🐛

* tag

* xlearn 🐛

* trying to remove exit -1

* trying to remove exit -1 🐛

* Remove html files in docs from being pushed

* trying to remove exit -1 🐛🐛

* trying to remove exit -1 failOnStderr

* trying to remove exit -1 💥

* trying to remove exit -1 💥💥

* new full run xlearn in

* trigger tag 🐛

* Edit CONTRIBUTING.md

* backoff

* 📝

* review 📝 in common

* wip

* deprec

* fix 📝

* removing dev branch, will trigger only with tag

* Fix docstrings in dataset and evaluation

* Fix ** in docstring

* Fix code example in docstring

* Reorder data sets in rst

* fix deeprec tests

* remove xlearn from core deps

* remove xlearn from core deps 🐛

* Add sections for each data set

* improve maybe download tests

* Edit dataset utils

* wip

* Add missing docstrings

* Fix list

Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Co-authored-by: Miguel González-Fierro <3491412+miguelgfierro@users.noreply.github.com>
* fix base model

* lightgcn, dkn

* reviewing deeprec

* SUM

Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
YanZhangADS and others added 17 commits June 14, 2021 14:32
* common

* common

* movielens

* cord

* mind

* 🐛

* downlowd

* deeprec

* deeprec

* 💥

* Update dataset.rst

* Update python_utils.py

* typo

* Update python_utils.py

* Update pandas_df_utils.py

* Update sparse.py

* Update sparse.py

Follow PEP8 for variable name

Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Co-authored-by: Andreas Argyriou <anargyri@users.noreply.github.com>
Co-authored-by: YanZhangADS <zhangya@microsoft.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@miguelgfierro
Copy link
Collaborator Author

miguelgfierro commented Jun 15, 2021

@YanZhangADS it looks there is a small error in the unit tests:


=================================== FAILURES ===================================
______________________________ test_df_to_sparse _______________________________

test_specs = {'number_of_items': 50, 'number_of_users': 20, 'seed': 123}
python_dataset =      userID  itemID  rating  timestamp
0         1       1       5 2020-06-07
1         1       2       2 2018-10-27
2...     3 2019-03-01
998      20      49       3 2020-08-05
999      20      50       3 2018-12-03

[830 rows x 4 columns]

    def test_df_to_sparse(test_specs, python_dataset):
        # initialize the splitter
        header = {
            "col_user": DEFAULT_USER_COL,
            "col_item": DEFAULT_ITEM_COL,
            "col_rating": DEFAULT_RATING_COL,
        }
    
        # instantiate the affinity matrix
>       am = AffinityMatrix(DF=python_dataset, **header)
E       TypeError: __init__() got an unexpected keyword argument 'DF'

tests/unit/reco_utils/dataset/test_sparse.py:92: TypeError

this is different to what we fixed in this PR #1447

@anargyri
Copy link
Collaborator

@YanZhangADS it looks there is a small error in the unit tests:


=================================== FAILURES ===================================
______________________________ test_df_to_sparse _______________________________

test_specs = {'number_of_items': 50, 'number_of_users': 20, 'seed': 123}
python_dataset =      userID  itemID  rating  timestamp
0         1       1       5 2020-06-07
1         1       2       2 2018-10-27
2...     3 2019-03-01
998      20      49       3 2020-08-05
999      20      50       3 2018-12-03

[830 rows x 4 columns]

    def test_df_to_sparse(test_specs, python_dataset):
        # initialize the splitter
        header = {
            "col_user": DEFAULT_USER_COL,
            "col_item": DEFAULT_ITEM_COL,
            "col_rating": DEFAULT_RATING_COL,
        }
    
        # instantiate the affinity matrix
>       am = AffinityMatrix(DF=python_dataset, **header)
E       TypeError: __init__() got an unexpected keyword argument 'DF'

tests/unit/reco_utils/dataset/test_sparse.py:92: TypeError

this is different to what we fixed in this PR #1447

Sorry I changed this. Let me fix it.

@miguelgfierro miguelgfierro merged commit b60746b into staging Jun 16, 2021
@miguelgfierro miguelgfierro deleted the pipeline_release branch June 16, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants