Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker image reference to internal registry #1727

Merged
merged 1 commit into from
May 30, 2022
Merged

Update docker image reference to internal registry #1727

merged 1 commit into from
May 30, 2022

Conversation

miguelgfierro
Copy link
Collaborator

@miguelgfierro miguelgfierro commented May 30, 2022 •
edited
Loading

Description

Adding Microsoft internal registry for our docker images

Related Issues

Fix #1725

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@miguelgfierro miguelgfierro merged commit b77bc33 into staging May 30, 2022
@miguelgfierro miguelgfierro deleted the miguel/docker branch May 30, 2022 12:50
gramhagen
gramhagen reviewed May 30, 2022
View reviewed changes
Copy link
Collaborator

@gramhagen gramhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gramhagen gramhagen gramhagen left review comments

@anargyri anargyri anargyri approved these changes

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miguelgfierro @gramhagen @anargyri