Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SAR notebooks #1738

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

ChuyangKe
Copy link
Contributor

Description

Fixed the error that in SAR notebooks, the TOP_K parameter is not properly supplied to function model.recommend_k_items().

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ChuyangKe ChuyangKe changed the title Fix SAR notebooks Fixed SAR notebooks Jun 9, 2022
Copy link
Collaborator

@gramhagen gramhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChuyangKe congrats for your first PR! Awesome!

@miguelgfierro
Copy link
Collaborator

miguelgfierro commented Jun 10, 2022

@pradnyeshjoshi this PR has an error with the AzureML credentials, same as #1736, however, this one doesn't have any error: #1739 Do you know what could be happening?

@pradnyeshjoshi
Copy link
Collaborator

pradnyeshjoshi commented Jun 10, 2022

@pradnyeshjoshi this PR has an error with the AzureML credentials, same as #1736, however, this one doesn't have any error: #1739 Do you know what could be happening?

@miguelgfierro Looks like @ChuyangKe has created a fork of the repo, and GitHub Actions has no way to make secrets available to forks, so it's not able to find the login credentials.

@ChuyangKe
Copy link
Contributor Author

k of the repo, and GitHub Actions has no way to make secrets available to forks, so it's not able to find the login credentials.

@pradnyeshjoshi Yes I created a fork to my account. Do I need to push in other ways?

@pradnyeshjoshi
Copy link
Collaborator

k of the repo, and GitHub Actions has no way to make secrets available to forks, so it's not able to find the login credentials.

@pradnyeshjoshi Yes I created a fork to my account. Do I need to push in other ways?

@ChuyangKe we usually create a feature branch off of staging in the same repo and create a pull request into staging. AzureML tests in this PR are failing because the credentials to log into AzureML (as part of unit test workflow) are stored as repo level secrets. I am looking into how we can support PRs from forks.

@miguelgfierro
Copy link
Collaborator

@pradnyeshjoshi the same thing is failing here: #1732 are you sure it is related to the fork?

@miguelgfierro
Copy link
Collaborator

@ChuyangKe I have added you to the repo, from now on, you don't have to create a fork, you just need to create a branch from staging and then PR to staging

@pradnyeshjoshi
Copy link
Collaborator

@pradnyeshjoshi the same thing is failing here: #1732 are you sure it is related to the fork?

@miguelgfierro In #1732, the error occurs because the group name mentioned in the workflow file does not exist anymore in the test_groups.py script. I will add another task to have the workflow pick up group names dynamically.

@miguelgfierro
Copy link
Collaborator

I'm rerunning again all the tests FYI @pradnyeshjoshi @ChuyangKe

@miguelgfierro
Copy link
Collaborator

I will merge this because I think with the new PR of @pradnyeshjoshi solved the AzureML issue

@miguelgfierro miguelgfierro merged commit 9ef2328 into recommenders-team:staging Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants