Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests for Python 3.8 and 3.9 #1756

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Added tests for Python 3.8 and 3.9 #1756

merged 2 commits into from
Jun 22, 2022

Conversation

pradnyeshjoshi
Copy link
Collaborator

@pradnyeshjoshi pradnyeshjoshi commented Jun 21, 2022 •
edited
Loading

Description

Added python 3.8 and 3.9 to github workflows for AzureML tests.

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@pradnyeshjoshi pradnyeshjoshi self-assigned this Jun 21, 2022
miguelgfierro
miguelgfierro approved these changes Jun 22, 2022
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that for scaling to python 3.8 and 3.9, you just need to add one line of code is a proof that this code is super strong. Really good job!

@pradnyeshjoshi pradnyeshjoshi merged commit e700c8d into staging Jun 22, 2022
@pradnyeshjoshi pradnyeshjoshi deleted the pradjoshi/test_py3839 branch June 22, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

Assignees

@pradnyeshjoshi pradnyeshjoshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pradnyeshjoshi @miguelgfierro