disabling rook mgr module in CephCluster #2776
Conversation
ShravaniVangur
force-pushed
the
disable-rook-module
branch
2 times, most recently
from
ca22af7
to
ebd7b00
Compare
Disable rook mgr module during installation with ODF. Signed-off-by: ShravaniVangur <shravanivangur@gmail.com>
ShravaniVangur
force-pushed
the
disable-rook-module
branch
from
ebd7b00
to
cd5cf2e
Compare
| @@ -1101,6 +1101,7 @@ func generateMgrSpec(sc *ocsv1.StorageCluster) rookCephv1.MgrSpec { | |||
| Modules: []rookCephv1.Module{ | |||
| {Name: "pg_autoscaler", Enabled: true}, | |||
| {Name: "balancer", Enabled: true}, | |||
| {Name: "rook", Enabled: false}, | |||
There was a problem hiding this comment.
Are we planning to keep it disabled permanently? I doubt 🤔
There was a problem hiding this comment.
Technically it is supposed to be disabled when it is installed. But due to some issues as observed in this bz: https://bugzilla.redhat.com/show_bug.cgi?id=2300312#add_comment the rook mgr module is enabled initially. This just makes sure that on installation it remains disabled. Can be enabled through the rook toolbox post installation.
Are we planning to keep it disabled permanently? I doubt 🤔
There was a problem hiding this comment.
Understood, but what if in future we would want to enable the module for some case? By disabling it this way, there would be clash between a user manually enabling it through toolbox and the operator reconciling it to disable.
@travisn is it guaranteed that in future as well we don't see any use case for rook-mgr module in ODF d/s?
There was a problem hiding this comment.
The rook mgr module is really only used by the upstream dashboard, which we don't use downstream. There is not currently a scenario to enable this module in the downstream. When it is enabled (though we are not sure the cause), it causes errors as we have seen in a couple customer clusters.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ShravaniVangur, travisn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 3162642
into
red-hat-storage:main
|
/cherry-pick release-4.17 |
|
@ShravaniVangur: new pull request created: #2786 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sometimes, during installation with ODF, the rook mgr module in ceph cluster is being enabled. This pr ensures that it is disabled during installation.
For example:
sh-4.4$ ceph mgr module ls | grep rookrook onWith this change:
sh-4.4$ ceph mgr module ls | grep rookrook -