Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODO and other tools should recognize managed services without knowing exact names of CRDs #90

Closed
wtrocki opened this issue Mar 1, 2021 · 13 comments

Comments

@wtrocki
Copy link
Collaborator

wtrocki commented Mar 1, 2021

Managed Kafka Connection needs to be recognized in ODO. This will not happen now as services are needed to be backed by deployment.

We need to start using annotations for Managed (Kafka) Connection objects.

@pmuir
Copy link
Collaborator

pmuir commented Mar 1, 2021

https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/#attaching-metadata-to-objects

Probably labels are useful as this is something you might want to select on.

@wtrocki wtrocki added this to the Operator Summit milestone Mar 1, 2021
@wtrocki
Copy link
Collaborator Author

wtrocki commented Mar 1, 2021

@secondsun I will create follow up issue to add support to ODO but I think we should attach labels now - this is not breaking change but having some labels under discussion will enable us to group them for multiservice environment.

Done some reading and there is no need to add new elements. Acording to
https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels

we can use:

app.kubernetes.io/component="external-service"
app.kubernetes.io/managed-by="rhoas"

not sure about external-service - naming are hot area but I think this is clear for everyone

@wtrocki wtrocki changed the title Add ServiceBindingConnection to odo cli so ODO will recognize managed kafka and future objects ODO and other tools should recognize managed kafka and future objects Mar 1, 2021
@secondsun secondsun self-assigned this Mar 1, 2021
@pmuir
Copy link
Collaborator

pmuir commented Mar 1, 2021

https://odo.dev/

@wtrocki
Copy link
Collaborator Author

wtrocki commented Mar 1, 2021

ODO ? memory-alpha.fandom.com/wiki/Odo

😆

@wtrocki wtrocki changed the title ODO and other tools should recognize managed kafka and future objects ODO and other tools should recognize managed services without knowing exact names of CRDs Mar 1, 2021
@secondsun
Copy link
Contributor

What does the perceived odo workflow look like, and where would we need to integrate with it? I am imagining a cluster with firepig installed and you odo make a java project then odo add mkc (yes I know these aren't odo commands, but pretend they are). odo will then make sure that the MKC values are injected into your java project/pod/deployment.

Is this an alternative to the service binding operator, or do they work hand in hand? is the target audience of odo people who are REALLY scared of yaml files?

@wtrocki
Copy link
Collaborator Author

wtrocki commented Mar 1, 2021

ODO just needs to recognize MKC as service. It does by having CR that.. has deployment.
Our case doesn't have deployment so we need to somehow teach odo that MKC MSRC etc. are the resources you can created binding for.

On the low level we can create binding between anything so there is no such limitation.

@wtrocki wtrocki removed the critical label Mar 1, 2021
@wtrocki
Copy link
Collaborator Author

wtrocki commented Mar 2, 2021

Started discussion on the ODO issue. I Will also mention this on the Friday call:

redhat-developer/odo#4236

@wtrocki
Copy link
Collaborator Author

wtrocki commented Mar 2, 2021

@secondsun I had some discussions about this and generally we should add labels:

app.kubernetes.io/component="external-service"
app.kubernetes.io/managed-by="rhoas"

No other action is needed for this issue.
Let's add those (I will not do it since you are assigned to that already)

@secondsun
Copy link
Contributor

All right, will do!

@secondsun
Copy link
Contributor

After doing some more research, I don't think the operator is the place were labels should be added. Labels should be applied when the crs are created either by the CLI or the BFF. I'll update the examples in the operator directory.

@secondsun secondsun reopened this Mar 2, 2021
@secondsun secondsun assigned wtrocki and secondsun and unassigned secondsun and wtrocki Mar 2, 2021
@wtrocki wtrocki modified the milestones: Operator Summit, Post Summit Mar 5, 2021
@wtrocki wtrocki removed their assignment Mar 5, 2021
@wtrocki
Copy link
Collaborator Author

wtrocki commented Mar 5, 2021

Leaving that for the time when we have extra service. There are couple strategies for grouping

@wtrocki
Copy link
Collaborator Author

wtrocki commented Mar 12, 2021

Recomendation was done to use groups for supported resources etc.
Closing as there will be no action for this needed.

@wtrocki wtrocki closed this as completed Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants