Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WebHooks which will autocreate necessary labels. #98

Closed
secondsun opened this issue Mar 2, 2021 · 1 comment
Closed

Add WebHooks which will autocreate necessary labels. #98

secondsun opened this issue Mar 2, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@secondsun
Copy link
Contributor

This is related to #90.

For the near term, labels will be manually added to custom resources by the clients that create them. In the long term we should adopt a mutating admission webhook.

https://docs.openshift.com/container-platform/4.6/operators/understanding/olm/olm-webhooks.html
@secondsun secondsun added the enhancement New feature or request label Mar 2, 2021
@secondsun secondsun mentioned this issue Mar 2, 2021
Open
@wtrocki
Copy link
Collaborator

wtrocki commented Mar 18, 2021 •
edited
Loading

Labels were closed as bad idea for the problem that doesn't exist.
However webhooks might be used for something else.

leaving for @secondsun to reopen if any other use case is needed

@wtrocki wtrocki closed this as completed Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wtrocki @secondsun