Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Compare cloud provider responses in unit tests #83

Closed
3 tasks done
miyunari opened this issue Oct 26, 2022 · 0 comments · Fixed by #154
Closed
3 tasks done

Compare cloud provider responses in unit tests #83

miyunari opened this issue Oct 26, 2022 · 0 comments · Fixed by #154
Assignees

Comments

@miyunari
Copy link
Member

miyunari commented Oct 26, 2022

Currently we are using the pre defined response in our cloud provider unit tests.

TODO:

  • read gcp response from a file
  • read azure response from a file
  • read aws response from a file

https://github.com/redhatcloudx/rhelocator/blob/3b24b2e345bc8dc17331f82e723da109c46dd046/tests/update_images/test_azure.py#L30-L47

We want to read a raw http response from a file. That way test responses can be updated independently.

current architecture

image

proposed architecture

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant