This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
test gcp filtering based on real data #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miyunari
force-pushed
the
read_test_response_from_json
branch
2 times, most recently
from
3901ef7
to
3942479
Compare
Signed-off-by: Janine Olear <pninak@web.de>
miyunari
force-pushed
the
read_test_response_from_json
branch
from
3942479
to
5e5cf4e
Compare
major
approved these changes
Nov 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does change our gcp unit test. From now it will use real data returned from gcp. Currently this list is generated manually.
using:
In the future that's what our job should do automatically every night/week.
part of #83