This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Convert google image data to json schema #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miyunari
changed the title
miyunari
changed the title
|
Changes looking great as usual. Only thing I'd like to add would be tests for your newly added functions to get the code coverage up again. Basically the same thing we did for AWS! |
|
Thank you 😄 I am currently working on the tests, that's why I made it a draft pull request for now 👍 |
miyunari
force-pushed
the
convert_image_data_to_JSON_schema_#95
branch
5 times, most recently
from
a77c925
to
34740ae
Compare
miyunari
force-pushed
the
convert_image_data_to_JSON_schema_#95
branch
3 times, most recently
from
c6e5203
to
83da1df
Compare
miyunari
requested review from
major and
F-X64
and removed request for
major
F-X64
previously requested changes
Nov 15, 2022
|
Just a minor issue with the version parsing that I didn't see before, other than that it looks great! |
miyunari
force-pushed
the
convert_image_data_to_JSON_schema_#95
branch
7 times, most recently
from
4ef1586
to
5e5460d
Compare
Signed-off-by: Janine Olear <pninak@web.de>
Signed-off-by: Janine Olear <pninak@web.de>
Signed-off-by: Janine Olear <pninak@web.de>
Signed-off-by: Janine Olear <pninak@web.de>
miyunari
force-pushed
the
convert_image_data_to_JSON_schema_#95
branch
4 times, most recently
from
ac5f51a
to
4132c86
Compare
Signed-off-by: Janine Olear <pninak@web.de>
miyunari
force-pushed
the
convert_image_data_to_JSON_schema_#95
branch
from
4132c86
to
febe0b7
Compare
major
dismissed
F-X64’s stale review
I think Nina got this fixed up in the latest revision.
major
approved these changes
Nov 16, 2022
tests/update_images/test_gcp.py
Outdated
|
|
||
|
|
||
| def test_format_image(): | ||
| """Test transforming a single google image into a schmea approved |
There was a problem hiding this comment.
Typo on schema here, but it's minor. 😜
Signed-off-by: Janine Olear <pninak@web.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #95