Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Add api server to container #156

Merged
merged 5 commits into from
Nov 29, 2022
Merged

Add api server to container #156

merged 5 commits into from
Nov 29, 2022

Conversation

F-X64
Copy link
Member

@F-X64 F-X64 commented Nov 25, 2022 •
edited
Loading

  • aws hourly cli command now outputs images for all regions by default. An individual region can still be supplied by using the --region flag.
  • api endpoint execition is added to the container file
  • small documentation on building and running the container locally

closes #131

@F-X64 F-X64 requested review from major and miyunari November 25, 2022 09:30
@F-X64 F-X64 force-pushed the add-api-server-to-container branch from dd4c120 to be69780 Compare November 25, 2022 09:34
miyunari
miyunari reviewed Nov 25, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@F-X64 F-X64 force-pushed the add-api-server-to-container branch from be69780 to 13f2409 Compare November 25, 2022 09:39
@F-X64 F-X64 force-pushed the add-api-server-to-container branch 2 times, most recently from eba4313 to fc2023f Compare November 25, 2022 10:18
@F-X64
Make aws-hourly cli command output images for all regions by default
a937669 
Modify aws-hourly-iamges cli command to output all regions by default
Modify cli test accordingly
Modify container_release workflow to output all iamges in one call
@F-X64 F-X64 force-pushed the add-api-server-to-container branch from fc2023f to 95c47a4 Compare November 28, 2022 06:56
F-X64 and others added 4 commits November 29, 2022 07:44
@F-X64
Add API server execution to container file
c684563
@F-X64
Add documentation
d061897
@F-X64 @miyunari
Update README.md
8d350d9 
Improvement suggested by @Myunari

Co-authored-by: Nina <54885993+miyunari@users.noreply.github.com>
@F-X64
Remove lines commited twice
7287965
@F-X64 F-X64 force-pushed the add-api-server-to-container branch from 84dfb82 to 7287965 Compare November 29, 2022 06:44
major
major approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@major major left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! We're getting so close now! 👏🏻

src/rhelocator/api/server.py
@@ -2,6 +2,7 @@

from flasgger import Swagger
from flask import Flask
from flask_cors import CORS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea on CORS. 😉

@major major merged commit 9b2cc13 into main Nov 29, 2022
@major major deleted the add-api-server-to-container branch November 29, 2022 12:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@miyunari miyunari miyunari left review comments

@major major major approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement API server deployment in container release
3 participants
@F-X64 @major @miyunari