This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
resolve name inconsistency #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miyunari
commented
Nov 30, 2022
|
|
||
| @gcp_endpoint.route("/gcp", methods=["GET"]) | ||
| @swag_from("../schema/gcp.yml") | ||
| @google_endpoint.route("/google", methods=["GET"]) |
There was a problem hiding this comment.
@FKolwa does it make sense to rename our endpoint too? Wasn't sure about this
There was a problem hiding this comment.
Hm. I'm a bit torn on this one too. I'd like to stay as consistent as possible but gcp would probably make more sense as an endpoint. I'd say we probably should stick to gcp.
There was a problem hiding this comment.
We decided to keep it to google, because otherwise we would have a lot of exceptions and inconsistency again.
miyunari
force-pushed
the
create_name_consistency_with_google_images_#117
branch
from
b521656
to
dce8ac6
Compare
Signed-off-by: Janine Olear <pninak@web.de>
miyunari
force-pushed
the
create_name_consistency_with_google_images_#117
branch
from
dce8ac6
to
d8901f4
Compare
|
Such consistency. 👏🏻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #117