This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
transform: Fix type checks #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #692 +/- ##
==========================================
- Coverage 92.11% 91.63% -0.48%
==========================================
Files 9 9
Lines 558 550 -8
Branches 127 118 -9
==========================================
- Hits 514 504 -10
- Misses 23 24 +1
- Partials 21 22 +1
☔ View full report in Codecov by Sentry. |
miyunari
reviewed
Jul 26, 2023
Remove all of the `@no_type_check` markers and use the `connection.DataEntry` type with all transformers. There are still some issues with passing a list to DataEntry when it expects to have a dictionary or `None` as its second argument. Because if mypy isn't happy, nobody is happy. 😉 Signed-off-by: Major Hayden <major@redhat.com>
major
force-pushed
the
transformer-type-checks
branch
from
3f379d1
to
49d3be1
Compare
miyunari
approved these changes
Jul 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all of the
@no_type_checkmarkers and use theconnection.DataEntrytype with all transformers. There are still some issues with passing a list to DataEntry when it expects to have a dictionary orNoneas its second argument.Because if mypy isn't happy, nobody is happy. 😉