Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Add Schema definition #90

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Add Schema definition #90

merged 1 commit into from
Nov 2, 2022

Conversation

F-X64
Copy link
Member

@F-X64 F-X64 commented Nov 2, 2022

The content of this schema is based on @miyunari and my proposal and is still up for discussion.
I'd like to get this out of my system for now and start integrating your feedback so we can move on and apply the necessary image data conversion to fit this schema.

The schema should be used to validate image data on

  • saving of newly obtained image data
  • loading of existing image data from our generated json file (e.g. on boot of the image locator API endpoint)

Am I missing something? Is there a specific image property that should be validated using regex?

Fixes #48

Copy link
Member

@miyunari miyunari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Member

@major major left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this as it stands now. I can try to help with the mypy issues this afternoon.

@major major merged commit 530a52d into main Nov 2, 2022
@major major deleted the add-json-schema branch November 2, 2022 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Determine a JSON schema
3 participants