Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RedisReadable and RedisWritable #1376

Open
wants to merge 2 commits into
base: v4
Choose a base branch
from
Open

Conversation

Uzlopak
Copy link

@Uzlopak Uzlopak commented Jul 1, 2021

This PR adds RedisReadable and RedisWritable to ioredis

These are convenient classes, which bring Redis Streams to the Node ecosystem.

add RedisReadable
add RedisWritable
expose RedisReadable and RedisWritable in index.ts
@Uzlopak
Copy link
Author

Uzlopak commented Jul 1, 2021

I refactored some code of mine, and have to write some unit tests in your format.

To Be done:

  • write unit tests
  • check if maxlen is correctly refactored
  • check if it can be instantiated correctly (is the export in index.ts is enough?)
  • write documentation
  • add objectMode
  • add consumergroup
  • add blocking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant