Add path to permission title

redlink-gmbh · Nov 19, 2017 · c87a30d · c87a30d
1 parent 8523456
commit c87a30d
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/packages/rocketchat-authorization/client/views/permissions.js b/packages/rocketchat-authorization/client/views/permissions.js
@@ -56,7 +56,19 @@ Template.permissionsTable.helpers({
 	},
 
 	permissionName(permission) {
-		return permission.level === permissionLevel.SETTING ? t(permission.settingId) : t(permission._id);
+		if (permission.level === permissionLevel.SETTING) {
+			let path = '';
+			if (permission.group) {
+				path = `${ t(permission.group) } > `;
+			}
+			if (permission.section) {
+				path = `${ path }${ t(permission.section) } > `;
+			}
+			path = `${ path }${ t(permission.settingId) }`;
+			return path;
+		} else {
+			return t(permission._id);
+		}
 	},
 
 	permissionDescription(permission) {

diff --git a/packages/rocketchat-authorization/server/publications/permissions.js b/packages/rocketchat-authorization/server/publications/permissions.js
@@ -28,7 +28,7 @@ Meteor.methods({
 		const records = RocketChat.models.Permissions.find({
 			level: permissionLevel.SETTING,
 			groupPermissionId: {$exists: true} //filter group permissions themselves, as they are being assigned implicitly
-		}).fetch();
+		}, {}, {sort:{group: 1, section: 1}}).fetch();
 
 		if (updatedAt instanceof Date) {
 			return {

diff --git a/packages/rocketchat-authorization/server/startup.js b/packages/rocketchat-authorization/server/startup.js
@@ -114,7 +114,9 @@ Meteor.startup(function() {
 		const permission = {
 			_id: permissionId,
 			level: permissionLevel.SETTING,
-			settingId: setting._id
+			settingId: setting._id,
+			group: setting.group,
+			section: setting.section
 		};
 		// copy previously assigned roles if available
 		if (previousSettingPermissions[permissionId] && previousSettingPermissions[permissionId].roles) {