slog: only include for golang 1.21+ #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This puts the slog-related bits into files that carry a build constraint of go1.21, i.e. are build only with golang 1.21 _and higher_. Effectively, it allows us to keep `go 1.20` in go.mod, allowing benthos to be used in projects that still support golang 1.20. Signed-off-by: Stephan Renatus <stephan@styra.com>
Jeffail
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Oh nice, thanks for setting this up @srenatus, I think I mistakenly thought this wasn't available yet due to golang/go#59033 remaining open but I guess it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts the slog-related bits into files that carry a build constraint of go1.21, i.e. are built only with golang 1.21 and higher.
Effectively, it allows us to keep
go 1.20in go.mod, allowing benthos to be used in projects that still support golang 1.20.