Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tooling #148

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

bojand
Copy link
Member

@bojand bojand commented May 24, 2024

Changes

Updates controller gen tool to version 0.15.0. With go 1.22.2 and 1.22.3 I was getting crash when generating code. It seems related to either kubernetes-sigs/controller-tools#880 or kubernetes-sigs/controller-tools#851. If I use to go version 1.21.10 it seems to work. Or if I update to version 0.14.0 or 0.15.0 of controller gen. This did change the YAML formatting of the manifests.

Updates testcontainers and redpanda module to version 0.29.1. This was needed due to some fixes for better support of non-Docker container runtimes like Podman and Rancher Desktop. Particularly there were fixes in the Redpanda module as well to improve support for these.
The version picked is due to testcontainers/testcontainers-go#2477 which causes issues with using 0.30.0 version.
As a result of updating testcontainers I needed to update oras.land/oras-go for some reason, as I was getting the following errors:

❯ ./task k8s:run-unit-tests
task: [k8s:run-go-vet] go vet ./...

# oras.land/oras-go/pkg/auth/docker
../../../../../go/pkg/mod/oras.land/oras-go@v1.2.4/pkg/auth/docker/login_tls.go:44:20: undefined: types.AuthConfig
../../../../../go/pkg/mod/oras.land/oras-go@v1.2.4/pkg/auth/docker/login_tls.go:62:131: undefined: types.AuthConfig
../../../../../go/pkg/mod/oras.land/oras-go@v1.2.4/pkg/auth/docker/login_tls.go:122:32: undefined: types.AuthConfig
../../../../../go/pkg/mod/oras.land/oras-go@v1.2.4/pkg/auth/docker/login.go:54:16: undefined: types.AuthConfig
exit status 1

Now k8s:run-unit-tests passes locally for me.

@bojand bojand marked this pull request as ready for review May 24, 2024 23:23
@bojand bojand force-pushed the bojand/update_controller_gen_and_testcontainers branch from 2d94760 to 9948c6c Compare May 28, 2024 13:46
@bojand bojand merged commit 8351c9f into main May 28, 2024
5 checks passed
@chrisseto chrisseto deleted the bojand/update_controller_gen_and_testcontainers branch May 28, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants