Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade version of "graphql-request" #3488

Conversation

donovan-ecargo
Copy link
Contributor

Upgrading the version of "graphql-request" to use the latest. This should help ensure the latest is in use, with all the bug fixes that come with it. Notably a fix for a typing conflict for AbortSignal.

I've requested if it was okay to update the package, but if there's a preference to open an issue more specific to updating the package, I'll happily open one.

Related issue where I asked for permission:
#2931

Upgrading the version of "graphql-request" to use the latest. This is
not only to get onto the latest version of the package, but also to
remove an internal bug to that can surface from it. In this case, there
are duplicate `AbortSignal` types, one defined by the Typescript
language, and one defined by the package. This update removes this
conflict.
@codesandbox
Copy link

codesandbox bot commented May 29, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@netlify
Copy link

netlify bot commented May 29, 2023

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 59f0720
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/6475201e6c42490007161a77
😎 Deploy Preview https://deploy-preview-3488--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 59f0720:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration

@blaenk
Copy link

blaenk commented Jul 20, 2023

Can we merge this?

@nzbart
Copy link

nzbart commented Sep 3, 2023

@markerikson would it be possible for you to merge this PR? It looks like you approved of the idea in the linked issue:

#2931 (comment)

@Jason-eCargo
Copy link

@markerikson Hi Mark, can this PR be merged? It should resolve the linked issue:

#2931 (comment)

@mwarger
Copy link

mwarger commented Dec 31, 2023

@donovan-ecargo Any chance we could also update the redux toolkit peer dependency while we're at it? With the release of RTK 2.0 this causes a dependency issue when installing:

npm ERR! Found: @reduxjs/toolkit@2.0.1
npm ERR! node_modules/@reduxjs/toolkit
npm ERR!   @reduxjs/toolkit@"^2.0.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @reduxjs/toolkit@"^1.7.1" from @rtk-query/graphql-request-base-query@2.2.0
npm ERR! node_modules/@rtk-query/graphql-request-base-query
npm ERR!   @rtk-query/graphql-request-base-query@"*" from the root project

If not, we could allow this in a separate PR. Thanks.

@phryneas
Copy link
Member

Damn, this sat open for far too long - unfortunately, I can't push any modifications to this branch and there are some slight modifications needed, so I'll have to do this on our side - reopening in #4026

I'll republish with a better peerDependency after.

@phryneas phryneas closed this Dec 31, 2023
@phryneas
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants