Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace es3ify with Babel ES3 transforms #1687

Closed
gaearon opened this issue May 1, 2016 · 2 comments
Closed

Replace es3ify with Babel ES3 transforms #1687

gaearon opened this issue May 1, 2016 · 2 comments
Labels
help wanted infrastructure

Comments

@gaearon
Copy link
Contributor

gaearon commented May 1, 2016 •
edited
Loading

The only reason it was added is because Babel ES3 transforms were broken.
They have since been fixed.

Now that es3ify itself is broken (see Travis), I’d appreciate somebody just putting those plugins in and removing es3ify from our build process.
chentsulin added a commit to chentsulin/redux that referenced this issue May 2, 2016
@chentsulin
Close reduxjs#1687, Replace es3ify with Babel ES3 transforms
9803bc6
@chentsulin
Copy link
Contributor

Submitted a PR at #1688

@gaearon gaearon closed this as completed in 0e80e7a May 2, 2016
@gaearon
Copy link
Contributor Author

gaearon commented May 2, 2016

Thank you!

seantcoyote pushed a commit to seantcoyote/redux that referenced this issue Jan 14, 2018
@chentsulin @seantcoyote
Close reduxjs#1687, Replace es3ify with Babel ES3 transforms (reduxjs…
9cd170b 
…#1688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaearon @chentsulin