-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Real world example does not work on master #2469
Comments
Those do not appear to be "real" errors, but rather ESLint warnings that are being marked as errors. I think CRA may have somewhat recently decided to enforce some ESLint rules as errors. Not sure on the right way to take care of this. |
Ok, that makes a lot more sense considering everything is actually defined that is reported. When linter errors take over the screen and don't let you actually see the app, though, I still consider them "real". 😄 How about a PR to disable those with /* eslint */ rules in those files? |
Some extra information: the example works if you do NOT do So, if you only install the modules in examples/real-world, it works. If you go up to the root redux folder, install the modules, then go back and reinstall in real-world and re-run the example app then these errors show up. |
Huh. That's... interesting. Some side effect of ESLint config resolution, I guess? |
Hi Mark
How are you doing?
I am Sasha and beginner for learning react-redux
I would like to learn about react and react-redux
Please give me good advice
Looking forward to hearing with you
Thanks, Sasha
…On Sat, Jun 24, 2017 at 5:04 AM, Mark Erikson ***@***.***> wrote:
Huh. That's... interesting. Some side effect of ESLint config resolution,
I guess?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2469 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AY3p3JCncZyMEa2araM0moW9G0sMfzYZks5sHChcgaJpZM4OEBaX>
.
|
@bbwstar : This is an issue tracker, not a help forum. That said, I keep a big list of links to high-quality tutorials and articles on React, Redux, and related topics, at https://github.com/markerikson/react-redux-links . Specifically intended to be a great starting point for anyone trying to learn the ecosystem, as well as a solid source of good info on more advanced topics. You should also check out the Reactiflux chat channels on Discord, at https://www.reactiflux.com . |
cd redux/examples/real-world
npm install
npm start
The real world example fails with the following errors:
If I pin all the dependencies to the exact version in examples/real-world/package.json, do another
npm install
, and try again I get similar errors but only reported for UserPage.js.So this appears to be an issue with the class properties transform not working properly, but I couldn't pinpoint the exact cause. If I figure out a solution I'll put up a PR.
The text was updated successfully, but these errors were encountered: