Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

human readable compose.js #1621

Closed
wants to merge 1 commit into from
Closed

Conversation

mondaychen
Copy link
Contributor

A more readable compose.js with some lodash utils.

@gaearon
Copy link
Contributor

gaearon commented Apr 15, 2016

Importing them from lodash top-level export rather than through individual modules is going to dramatically increase the UMD build size because it will bundle the whole Lodash with Redux. This is definitely not we want.

Even importing these modules directly, the utlities you use here will add a lot of code to Redux that we don’t actually need. You can verify it yourself by running npm run build and checking the size of the compiled bundle. I’m closing for this reason.

Thanks you for sending a PR!

@gaearon gaearon closed this Apr 15, 2016
@gaearon
Copy link
Contributor

gaearon commented Apr 15, 2016

I’m up for replacing (...args) => args[0] with arg => arg though!

@mondaychen
Copy link
Contributor Author

@gaearon understood. And I will only replace ...args #1622

@gaearon
Copy link
Contributor

gaearon commented Apr 15, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants