writing tests for middleware example changed #2496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed some issues, and tested it against the actual redux-thunk. Ready for review. |
|
LGTM. Anyone else want to give it a sanity check? |
|
LGTM too. |
seantcoyote
pushed a commit
to seantcoyote/redux
that referenced
this pull request
Jan 14, 2018
* writing tests for middleware example changed, reduxjs#559 * note about mock impls * backticks to single quotes * better first test * semi * back ticks around `create`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think thunk is a better example than 'singleDispatch'. The example is also more copy/paste-able.