Infer action types from combineReducers #3411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows for `combineReducers` to completely infer both the state and action types for its returned reducer. From experience with large TypeScript projects, it's common to see that the action type is not explicitly specified, which results in `AnyAction` in the resulting reducer type. Unfortunately, this will propagate through the type inference for `createStore` resulting in `dispatch` being very weakly typed. This change alone causes a chain reaction of a more correctly (and strongly) typed project with regards to Redux.
|
Deploy preview for redux-docs ready! Built with commit 6fe5614 |
|
Ah, good use of the Looks like some other formatting things came up unrelated to this PR. I'll see about fixing that up for you. |
This was referenced Sep 23, 2019
This was referenced Mar 11, 2020
This was referenced Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows for
combineReducersto completely infer both the state and action types for its returned reducer.From experience with large TypeScript projects, it's common to see that the action type is not explicitly specified, which results in
AnyActionin the resulting reducer type. Unfortunately, this will propagate through the type inference forcreateStoreresulting indispatchbeing very weakly typed. This change alone causes a chain reaction of a more correctly (and strongly) typed project with regards to Redux.