Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optionally integrate with num-cmp #155

Merged
merged 1 commit into from
Sep 25, 2024
Merged

feat: optionally integrate with num-cmp #155

merged 1 commit into from
Sep 25, 2024

Conversation

tisonkun
Copy link
Contributor

This closes #154.

@tisonkun
feat: optionally integrate with num-cmp
f89a933 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Contributor Author

But to implement impl<T, U> NumCmp<OrderedFloat<T>> for U the other side conflicts. Perhaps we should do on the upstream anyway. However, the upstream isn't updated over 7 years ...

mbrubeck
mbrubeck approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@mbrubeck mbrubeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mbrubeck mbrubeck merged commit 20d8033 into reem:master Sep 25, 2024
2 checks passed
@tisonkun tisonkun deleted the num-cmp branch September 25, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrubeck mbrubeck mbrubeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement NumCmp for OrderedFloat as if f32/f64
2 participants
@tisonkun @mbrubeck