chore: update telescope #89
Conversation
|
utACK @aaronc generally looks good. Are there any concerns around breaking changes? I'm not sure how to test or look for that. If you think that isn't a concern to be worried about, I can mark this as approved and we can get it merged. |
|
The underlying osmonauts dependencies throw runtime errors asking to upgrade so at least for me it's impossible to use this package without this PR. No idea how this is working in our app currently. @blushi can you take a quick look? |
Currently our app is not using the latest version of @regen-network/api that's based on telescope but a former one that was just based on ts-proto with a custom implementation. There's quite a bit of work involved to migrate and that hasn't been prioritized. Telescope-based version of this package is used in groups-ui though. But AFAIK, there were also some issues with amino signing with telescope that @ryanchristo had faced in particular when working with groups-ui (see regen-network/groups-ui#105 and #70). But not sure if it's a concern anymore with latest version. What do you want to use this for? |
So I was trying to play around with an idea of a data explorer after chatting with @clevinson about the idea. Basically some sort of really data focused blockchain explorer, that would look at the metadata on credits and try to resolve it with the data module and verify hashes for users. |
There was a problem hiding this comment.
Looks like Groups UI is indeed importing directly v1.0.0-alpha5. So we just need to make sure that we don't change that dependency (to a subsequent alpha, or official release of v1.0.0) without doing a thorough set of testing?
Would it be smart for us to bump the version of this package on main (to either a v1.1.0 or v2.0.0) since this may result in breaking changes?
Pre-approving as I'm fine with letting @aaronc make the call. Just wanted to surface my initial concerns.
|
We'll check before we update the groups UI. |
No description provided.