Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions for credit class creation #425

Closed
2 tasks
ruhatch opened this issue Jul 20, 2021 · 4 comments · Fixed by #426
Closed
2 tasks

Add permissions for credit class creation #425

ruhatch opened this issue Jul 20, 2021 · 4 comments · Fixed by #426
Assignees
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Feature New feature or request

Comments

@ruhatch
Copy link
Contributor

ruhatch commented Jul 20, 2021

Background

We haven't finalised the design of credit classes, but we want to release something for community/stakeholder feedback. We can release something, but maintain the ability to change it later by adding a whitelist of credit class designers, containing only RND keys. This gives us central control over credit creation, which allows us to tweak the design based on feedback.

Implementation

To do this we need to:

  • Add a credit class designers whitelist as a governance parameter
  • Check that designers are on the whitelist when creating classes
@ruhatch
Copy link
Contributor Author

ruhatch commented Jul 20, 2021

@aaronc should we store the whitelist as a governance parameter, just hardcoded perhaps, or something else?

@ruhatch ruhatch added Scope: x/ecocredit Issues that update the x/ecocredit module Type: Feature New feature or request labels Jul 20, 2021
@aaronc
Copy link
Member

aaronc commented Jul 20, 2021

As a governance parameter I think

@technicallyty technicallyty self-assigned this Jul 20, 2021
@technicallyty
Copy link
Contributor

should there also be a gov param to whether this allowlist is turned on or off? or maybe if the len(allowlist) == 0 means its off?

@aaronc
Copy link
Member

aaronc commented Jul 21, 2021

Maybe, but I think we want empty allow list to actually mean no credit classes can be created. It may be that way when we launch. So maybe there's another bool to allow all addresses.

@ruhatch ruhatch added this to the v1.1 - Baikal Upgrade milestone Jul 21, 2021
ruhatch pushed a commit that referenced this issue Aug 7, 2021
Closes: #425

Add new gov params for permissioned credit creation

Fix error in app/regen/cmd/genaccounts.go - couldn't compile due to error of cdc casting to itself
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants