feat!: Record retirement location for ecocredit module (#328) #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #384 +/- ##
==========================================
- Coverage 61.08% 59.85% -1.23%
==========================================
Files 51 56 +5
Lines 3325 3403 +78
==========================================
+ Hits 2031 2037 +6
- Misses 1030 1102 +72
Partials 264 264
Flags with carried forward coverage won't be shown. Click here to find out more. |
ruhatch
force-pushed
the
ruhatch/retirement-location
branch
from
f74b52e
to
7780fc6
Compare
amaury1093
reviewed
Jun 17, 2021
blushi
reviewed
Jun 17, 2021
ruhatch
commented
Jun 17, 2021
aaronc
reviewed
Jun 17, 2021
|
Also need to add |
aaronc
reviewed
Jun 18, 2021
ruhatch
force-pushed
the
ruhatch/retirement-location
branch
from
d93d6bb
to
8a03ae6
Compare
aaronc
approved these changes
Jun 29, 2021
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if !retiredUnits.IsZero() { | ||
| err = validateLocation(iss.RetirementLocation) |
There was a problem hiding this comment.
@blushi @clevinson do we always require a valid location? Could someone retire credits without providing a location theoretically?
There was a problem hiding this comment.
I don't think so, this should be required as long as credits get retired
There was a problem hiding this comment.
@blushi is it worth a final check with Ron?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #328
This PR introduces retirement locations for ecocredits. The retirement location is the location of the beneficiary or buyer of the retired credits. It is a string of the form
<country-code>[-<sub-national-code>[-<postal-code>]], with the first two fields conforming to the ISO 3166-2 standard. The location is emitted during retirement events and can therefore be tracked by an indexer.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change