feat!: Add dates as a top level field to credit batches (#393) #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
==========================================
+ Coverage 55.10% 56.09% +0.99%
==========================================
Files 33 59 +26
Lines 931 3742 +2811
==========================================
+ Hits 513 2099 +1586
- Misses 376 1372 +996
- Partials 42 271 +229
Flags with carried forward coverage won't be shown. Click here to find out more. |
aaronc
reviewed
Jul 12, 2021
ruhatch
force-pushed
the
ruhatch/batch-dates
branch
from
410844d
to
605c3f4
Compare
robert-zaremba
approved these changes
Jul 14, 2021
| @@ -30,6 +30,14 @@ message EventCreateBatch { | |||
|
|
|||
| // total_amount is the total number of credits in the credit batch. | |||
| string total_amount = 4 [ (gogoproto.moretags) = "yaml:\"total_amount\"" ]; | |||
|
|
|||
| // start_date is the beginning of the period during which this credit batch | |||
| // was quantified and verified. | |||
There was a problem hiding this comment.
instead of copying, how about saying:
start data is the MsgCreateBatchRequest.start_date value
Same for end_date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
start_dateandend_datefields toBatchInfoand associatedMsgCreateBatchRequest. These dates track the period during which the credit batch was quantified and verified.Closes: #393
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change