-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: improve example/docs getting version from jar manifest #1663
Comments
Note that the This should be mentioned in the documentation. |
And also if that MANIFEST.MF exists, but does not have the Implementation-Version property. Which happens to be the default for Maven's Archiver: https://maven.apache.org/shared/maven-archiver/index.html#class_manifest |
Some observations from my end:
I'm not sure if approach 1 really can't be adapted for modular code. Neither can I ensure approach 3 always works. But hopefully, someone else can step in and explain if approach 3 is a viable alternative to VersionProvider2.java for modular code. |
See remkop/picocli#1663 Change-Id: I9c35e336dd06956967d3a07318c1f397b8518091
As suggested by @rileynull in #236 (comment), the example showing how to get version information from the manifest may be overly convoluted.
TODO: Experiment with this and update the docs if this works as expected.
(Potential example for the manual:
The text was updated successfully, but these errors were encountered: