Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support cachePrivatePackages option for datasource index level #30120

Merged
merged 3 commits into from
Jul 12, 2024
Merged

feat: Support cachePrivatePackages option for datasource index level #30120

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1942781
feat: Support `cachePrivatePackages` option for datasource index level
zharinov Jul 10, 2024
004edde
Fix lint
zharinov Jul 10, 2024
41accfc
Merge branch 'main' into feat/force-cache-datasource-index
zharinov Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions lib/modules/datasource/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import is from '@sindresorhus/is';
import { dequal } from 'dequal';
import { GlobalConfig } from '../../config/global';
import { HOST_DISABLED } from '../../constants/error-messages';
import { logger } from '../../logger';
import { ExternalHostError } from '../../types/errors/external-host-error';
Expand Down Expand Up @@ -79,10 +80,16 @@ async function getRegistryReleases(
res.registryUrl ??= registryUrl;
}
// cache non-null responses unless marked as private
if (datasource.caching && res && !res.isPrivate) {
logger.trace({ cacheKey }, 'Caching datasource response');
const cacheMinutes = 15;
await packageCache.set(cacheNamespace, cacheKey, res, cacheMinutes);
if (datasource.caching && res) {
const cachePrivatePackages = GlobalConfig.get(
'cachePrivatePackages',
false,
);
if (cachePrivatePackages || !res.isPrivate) {
logger.trace({ cacheKey }, 'Caching datasource response');
const cacheMinutes = 15;
await packageCache.set(cacheNamespace, cacheKey, res, cacheMinutes);
}
}
return res;
}
Expand Down