Broken links to remote repositories

[gok99]

This issue consolidates issues with links in the report to remote repositories. These links should be fixed for when (a) no remote repositories exist or (b) remote repository is not yet supported by RepoSense (is not Github, GitLab or Bitbucket). The following report links redirect to broken links if either of the above conditions are satisfied.

1. Commit ramp link (also mentioned in Clicking on ramps in ramp chart generated using local repos redirects to non-existent link #231):
   
2. Link to author profile
   
3. Link to group repo tree
   
4. Link to blame view
   
5. Link to history view
   

To discuss:

What should be the expected behaviour in the above scenarios if either (a) or (b) is satisfied? Some options:

• Hide the links entirely
• Popover that explains that link is not available

[gok99]

Report links with remote repositories that are supported and not GitHub (either GitLab or Bitbucket) are expected to be fixed in #1644.

[chan-j-d]

Current links behaviour on master branch as of 1 April 2022

#1644 has standardized the behaviour of links to be

• Repository cloned from GitHub/GitLab/BitBucket - All links work
• All other types of repos (local or unsupported remote) - Links are disabled but buttons look identical

#1679 should allow partial support of local repos cloned from remote repos to support links that are already present on the remote repo.

[chan-j-d]

Besides the two suggestions you have, I might add an 'intermediate' suggestion where

• The buttons are present but the hover message states that the link does not work

[zhoukerrr]

@chan-j-d Actually I prefer the button to be hidden entirely or disabled because sometimes we click the button before seeing the hover message.

[gok99]

Actually I prefer the button to be hidden entirely or disabled

I think I agree. There is no ambiguity that a link is not supported if there isn't a link (icon) in the first place

[Jay-luozhijie]

Hi is this issue still open? It is OK to work on this issue?

[gok99]

Sure, I've assigned you the issue!

[Jay-luozhijie]

OK thanks! Shall I hide the button when the link doesn't work?

[gok99]

Yes, that appears to be the conclusion from above.

@Zhou-Jiahao-1998, do update this thread if you have better ideas for handling missing/unsupported remotes.

[zhoukerrr]

@gok99 Actually now that I think about it again, I prefer disabling the button and add a hover message. That way the user won't be able to click and is likely gonna see an explanation in the hover message. Hiding without stating anything might cause confusion?

[gok99]

@Zhou-Jiahao-1998 That makes sense!

@LuoZhijie-tom You could do this instead. Perhaps something like This remote link is unsupported

[Jay-luozhijie]

OK sure!