Duplication between the User Interface and class
#1973
Assignees
Labels
Comments
This was referenced Jan 20, 2024
ckcherry23
pushed a commit
that referenced
this issue
Jan 26, 2024
Remove utils/user.ts, replace with User interface from types.ts The User class and interface are equivalent in their usage and their redundancy seems to be a remnant when the code was migrated from JS to TS. Let's remove the User class for consistency and to improve runtime performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What feature(s) would you like to see in RepoSense
As is mentioned in #1965, there are currently a TypeScript interface of
Userintypes/types.tsand a JavaScript class ofUserinutils/User.ts.The difference between them is that theHowever, as the interface and the class are mostly equivalent, it will be reasonable to remove either of them.commitsattribute in the interface is optional while it is not in the class.Is the feature request related to a problem?
The interchangeable usage of the
UserInterface and class implies possible inconsistency.If possible, describe the solution
Remove either the interface or the class. Removing the class seems to give more advantages considering the runtime.
If applicable, describe alternatives you've considered
Removing the interface may also be reasonable as it may allow more flexibility with class methods in a future context.
Additional context
The text was updated successfully, but these errors were encountered: