Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breakdown by file type not retained after refresh #2016

Closed
germainelee02 opened this issue Jul 2, 2023 · 1 comment · Fixed by #2086
Closed

Breakdown by file type not retained after refresh #2016

germainelee02 opened this issue Jul 2, 2023 · 1 comment · Fixed by #2086
Assignees
@jonasongg
Labels
c.Bug p.High

Comments

@germainelee02
Copy link
Contributor

Please include the steps to reproduce the bug.

  1. Open a report
  2. Check 'breakdown by file type'
  3. Check 'all'
  4. Refresh

What was expected to happen?

The checked files should be retained after refreshing.

What actually happened? Please include a screenshot of the output.

After each refresh, the files become unchecked one by one

Bug.Report.Screen.Recording.mov
@ckcherry23 ckcherry23 mentioned this issue Jul 29, 2023
Merged
@ckcherry23
Copy link
Member

To anyone working on this issue, please add Cypress test cases and check that the test cases in frontend/cypress/tests/codeView/codeView_renderFilterHash.cy.js have the expected behaviour.

@jonasongg jonasongg self-assigned this Jan 20, 2024
@jonasongg jonasongg mentioned this issue Jan 20, 2024
Merged
@sopa301 sopa301 mentioned this issue Jan 22, 2024
Closed
ckcherry23 pushed a commit that referenced this issue Jan 31, 2024
@jonasongg
[#2016] Remove hash symbol from URL when decoding hash (#2086)
0f682a0 
Fix bug where some params were not retained after refresh

The issue pertains to breakdown of file types disappearing after a
refresh, but it seems to apply to all params that were last in the URL
due to symbols not being filtered out correctly.

Let's fix this issue to make sure the state of the report stays the
same when refreshing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonasongg jonasongg

Labels
c.Bug p.High
Projects
RepoSense Roadmap
Status: Closed/Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#2016] Remove hash symbol from URL when decoding hash jonasongg/RepoSense
3 participants
@ckcherry23 @germainelee02 @jonasongg