Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1572] Accept different types of URLs besides https github #1644
[#1572] Accept different types of URLs besides https github #1644
Changes from 105 commits
0dcdafe
17091d7
9d4b3e8
1746b05
e42e297
8463060
842d791
6b402c0
bf074d8
ad8e43e
a73e5e7
6ef5ccd
a94ded4
e9ea264
4d4bda1
15ea7f1
e44243d
9dcf667
e294d7a
c71b11b
0773e3e
3ad7cf7
21545fb
3b1c21a
2f763bc
a4328a4
2e65395
0604203
bd305f4
2537bea
2d7ecc9
3be3d64
cb6c5c8
6c0853b
931aab4
8314465
707d661
c552675
991bb1a
927ce3b
294a023
496ba31
adc344d
c26250d
7bd74f5
342dc02
c029c58
a55f2d3
e4af539
c4d9a0b
51ff1a2
34ec18c
e0402d6
d6b1711
4cd9fd1
7765314
712169d
124d39c
57e5d6e
81c9e81
9734f85
0f2cb5a
38ab0f1
765d227
0ca269b
4486fca
8a445f1
44ebaf1
c4dc164
294fc9e
16c7db6
20b7991
fbb840d
2987656
ed9df69
60f57e3
067dee8
d4fe602
66b11d9
fe4f92d
b3167fe
5053e69
2622251
819eab8
df6aa9c
dc5fa71
a130820
ba5fa38
7938863
2dc1317
8cee7b1
d9e3c6d
96b807d
550080d
871a770
06a1820
a7b03c5
a2efe36
a733840
2359d6a
a59c6a9
2c4eaeb
78b114c
179b66b
5a659c7
7576b50
5f48dfc
2a62b79
4b09e9e
70e2141
d238d02
104baf2
1f7b75e
1dd063e
e07dbd5
6d7529a
3e4d451
3fbc3d7
e007f2a
0c2ca41
7cebe8a
03939b0
5f9e45f
ff08591
5fa477e
2d00bc5
804f8c3
6583b0f
a577c12
f6083b5
3faefcf
a5cff50
e12182e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icon for this still shows a GitHub logo, might have to find another icon that is more suitable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅 I can't think of anything too good. I think the
git
logo might be fitting for this though I'm unclear on anything related to licensing on this matter. I'll add it so that you can take a lookThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm the git logo seems weird here, what about
fa-file-code
orfa-file-lines
? Gitlab seems to use the file-lines icon:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Between the two, I prefer file-code. I'll put forward this suggestion though
Since I think it's a pretty common image for remote repositories, especially in images illustrating the forking workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated it to
fa-file-code
, do take a look. Thanks!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@damithc Prof, do you have any thoughts about the icon to use to represent the link to the actual repository? Previously we were using the GitHub logo and it looks like this:
We are currently evaluating the following options to replace this logo so that it is more general and not GitHub-specific:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For generic icon, perhaps the
database
one? Also, fontawsome has this icon for git which may be suitable.It would be cool if we can use respective github, gitlab, and bitbucket icons (fontawesome has all three) when we know the repo is one of them, but that can be a separate enhancement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've chosen to settle on the
database
icon for now. I've tried thegit-alt
icon and it appears really small on the actual report with the branch lines being barely visible.This suggestion about the respective icons is really interesting! I think I'll create a new issue for it as I'm not too familiar with how to implement that right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice use of abstraction