Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1681] Fix log output for cloneFromBareAndUpdateBranch failures #1683

Merged
merged 2 commits into from
Feb 24, 2022
Merged

[#1681] Fix log output for cloneFromBareAndUpdateBranch failures #1683

merged 2 commits into from
Feb 24, 2022

Conversation

chan-j-d
Copy link
Contributor

@chan-j-d chan-j-d commented Feb 21, 2022 •
edited by dcshzj
Loading

Fixes #1681

The current logging message for the GitClone::cloneFromBareAndUpateBranch method does not include the exception and thus does not show the stack trace in the log output. The error message for CommandRunnerProcessException in the CommandRunnerProcess class is missing a space which can make the log output confusing.

Commit message:

Logging done upon failure in GitClone::cloneFromBareAndUpdateBranch 
does not include the stack trace. There is also a missing space in the 
logged error message for commands that fail, which can make the log
output confusing to read and trace.

Let's fix these logging issues.

@chan-j-d chan-j-d requested a review from a team February 21, 2022 05:23
yhtMinceraft1010X
yhtMinceraft1010X reviewed Feb 21, 2022
View reviewed changes
Copy link
Contributor

@yhtMinceraft1010X yhtMinceraft1010X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chan-j-d chan-j-d requested a review from a team February 21, 2022 05:45
dcshzj
dcshzj approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@dcshzj dcshzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will merge directly.

@dcshzj dcshzj changed the title [#1681] Fix log output for clone failure with cloneFromBareAndUpdateBranch [#1681] Fix log output for cloneFromBareAndUpdateBranch failures Feb 24, 2022
@dcshzj dcshzj merged commit 40dab6e into reposense:master Feb 24, 2022
@github-actions
Copy link
Contributor

The following links are for previewing this pull request:

@chan-j-d chan-j-d mentioned this pull request Mar 13, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcshzj dcshzj dcshzj approved these changes

@yhtMinceraft1010X yhtMinceraft1010X yhtMinceraft1010X approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log file for failure while executing cloneFromBareAndUpdateBranch not descriptive
3 participants
@chan-j-d @dcshzj @yhtMinceraft1010X