-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1726] Add support for GitLab and Bitbucket test repos #1805
Conversation
I don't think this "Fixes #1726", just part of it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! All the links (blame, history, commit, author, repo) seem to be working
Ah yes my bad, updated now. |
I see you created the reposense group in GitLab. @damithc would it be an issue? Would it be good if you are made an owner of that group on GitLab as well? |
Yes, perhaps safer to add me as an owner, for purposes of continuity. |
@damithc Do you have a GitLab ID that can be added? @SkyBlaise99 are you able to add Prof @damithc as an owner on GitLab? |
Sure. Prof @damithc, what's your ID? Or I can add any of you first. |
|
Just sent an invite. Do let me know if there's any issue. |
Received. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I think for BitBucket it is not too much of a concern. If the CI fails in the future due to missing repo, I think we can safely find a replacement.
Hi @dcshzj can you merge this as soon as possible as my IWM is coming to an end? Thank you. |
The following links are for previewing this pull request:
|
Part of #1726
Proposed commit message
Other information
Part 5 of #1726