Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1726] Add support for GitLab and Bitbucket test repos #1805

Merged
merged 5 commits into from
Jul 29, 2022

Conversation

SkyBlaise99
Copy link
Contributor

@SkyBlaise99 SkyBlaise99 commented Jul 12, 2022

Part of #1726

Proposed commit message

Currently, only GitHub repos are used for testing.

As we allow more repository types, we should also include repos from 
other platforms that we now support, namely GitLab and BitBucket.

Let's add GitLab and BitBucket repositories for testing.

Other information

Part 5 of #1726

@SkyBlaise99 SkyBlaise99 marked this pull request as ready for review July 12, 2022 02:57
@chan-j-d
Copy link
Contributor

I don't think this "Fixes #1726", just part of it

Copy link
Contributor

@chan-j-d chan-j-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! All the links (blame, history, commit, author, repo) seem to be working

@chan-j-d chan-j-d requested a review from a team July 12, 2022 15:14
@SkyBlaise99
Copy link
Contributor Author

I don't think this "Fixes #1726", just part of it

Ah yes my bad, updated now.

@dcshzj
Copy link
Member

dcshzj commented Jul 23, 2022

I see you created the reposense group in GitLab.

@damithc would it be an issue? Would it be good if you are made an owner of that group on GitLab as well?

@damithc
Copy link
Collaborator

damithc commented Jul 23, 2022

I see you created the reposense group in GitLab.

@damithc would it be an issue? Would it be good if you are made an owner of that group on GitLab as well?

Yes, perhaps safer to add me as an owner, for purposes of continuity.

@dcshzj
Copy link
Member

dcshzj commented Jul 23, 2022

@damithc Do you have a GitLab ID that can be added? @SkyBlaise99 are you able to add Prof @damithc as an owner on GitLab?

@SkyBlaise99
Copy link
Contributor Author

SkyBlaise99 commented Jul 23, 2022

Sure. Prof @damithc, what's your ID? Or I can add any of you first.

@damithc
Copy link
Collaborator

damithc commented Jul 23, 2022

Sure. Prof @damithc, what's your ID? Or I can add any of you first.

@damithcr

@SkyBlaise99
Copy link
Contributor Author

Just sent an invite. Do let me know if there's any issue.

@damithc
Copy link
Collaborator

damithc commented Jul 23, 2022

Just sent an invite. Do let me know if there's any issue.

Received. 👍

Copy link
Member

@dcshzj dcshzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I think for BitBucket it is not too much of a concern. If the CI fails in the future due to missing repo, I think we can safely find a replacement.

@SkyBlaise99
Copy link
Contributor Author

Hi @dcshzj can you merge this as soon as possible as my IWM is coming to an end? Thank you.

@dcshzj dcshzj changed the title [#1726] More test repos [#1726] Add support for GitLab and Bitbucket test repos Jul 29, 2022
@dcshzj dcshzj merged commit c4ba0de into reposense:master Jul 29, 2022
@github-actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants