-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1878] Updating SystemTestUtil::assertJson
to compare Json objects instead of line-by-line analysis
#2087
[#1878] Updating SystemTestUtil::assertJson
to compare Json objects instead of line-by-line analysis
#2087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is strictly necessary, but you might want to put both FileReader instantiations in the try () block so that they will automatically close. Otherwise, LGTM!
That's a good suggestion! I will look into moving FileReader into the try-with-resources clause! |
@jonasongg Just an update, but after having reviewed the code, it seems that both instances of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice job
The following links are for previewing this pull request:
|
Fixes #1878
Proposed commit message
Other information
The original issue alludes to the use of
JsonObject
in the fixes, however, while trying to get the system test cases to run, it appears that this method is to be used onJsonObject
andJsonArray
as well.JsonElement
was hence chosen as a suitable class that encapsulates the information of the parsed JSON objects, while allowing for equality of the JSON objects to be checked.