Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2231] CI failing for macos-11 JDK 11 #2236

Merged
merged 1 commit into from
Jul 14, 2024
Merged

[#2231] CI failing for macos-11 JDK 11 #2236

merged 1 commit into from
Jul 14, 2024

Conversation

georgetayqy
Copy link
Contributor

Fixes #2231

Proposed commit message

Given that the macos-11 GitHub Runner has been decommissioned, let's
move to migrate to macos-12 and macos-13 GitHub Runners to fix the
issue of failing CI.

Other information

N/A

@georgetayqy georgetayqy requested review from ckcherry23 and a team July 14, 2024 10:33
ckcherry23
ckcherry23 approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @asdfghjkxd!

@chan-j-d Can you help remove the CI status check requirement for macOS-11?

@chan-j-d
Copy link
Contributor

@ckcherry23 It's done. Would you like to merge it?

@ckcherry23 ckcherry23 merged commit 538e001 into reposense:master Jul 14, 2024
10 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckcherry23 ckcherry23 ckcherry23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI failing for macos-11 JDK 11
3 participants
@georgetayqy @chan-j-d @ckcherry23