use asyncComponent func

rescript-lang · Sep 12, 2023 · bb0302e · bb0302e
1 parent 9887129
commit bb0302e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 18 deletions.
diff --git a/jscomp/syntax/src/react_jsx_common.ml b/jscomp/syntax/src/react_jsx_common.ml
@@ -77,12 +77,14 @@ let add_async_attribute ~async (body : Parsetree.expression) =
 let is_async : Parsetree.attribute -> bool =
  fun ({txt}, _) -> txt = "async" || txt = "res.async"
 
-let async_component expr =
-  let open Ast_helper in
-  Exp.apply
-    (Exp.ident
-       {
-         loc = Location.none;
-         txt = Ldot (Lident "JsxPPXReactSupport", "asyncComponent");
-       })
-    [(Nolabel, expr)]
+let async_component ~async expr =
+  if async then
+    let open Ast_helper in
+    Exp.apply
+      (Exp.ident
+         {
+           loc = Location.none;
+           txt = Ldot (Lident "JsxPPXReactSupport", "asyncComponent");
+         })
+      [(Nolabel, expr)]
+  else expr
diff --git a/jscomp/syntax/src/reactjs_jsx_v4.ml b/jscomp/syntax/src/reactjs_jsx_v4.ml
@@ -970,15 +970,7 @@ let mapBinding ~config ~emptyLoc ~pstr_loc ~fileName ~recFlag binding =
       else fullExpression
     in
     let fullExpression =
-      if isAsync then
-        Exp.apply
-          (Exp.ident
-             {
-               loc = Location.none;
-               txt = Ldot (Lident "JsxPPXReactSupport", "asyncComponent");
-             })
-          [(Nolabel, fullExpression)]
-      else fullExpression
+      React_jsx_common.async_component ~async:isAsync fullExpression
     in
     let fullExpression =
       match fullModuleName with