Update watcher rules #6420
Merged
Update watcher rules #6420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review |
cknitt
reviewed
Oct 9, 2023
DZakh
force-pushed
the
update-watch-rules
branch
from
af114fc
to
d6deab5
Compare
DZakh
commented
Oct 9, 2023
rescript
Outdated
| @@ -239,6 +221,14 @@ if (maybeSubcommand === "build" && process_argv.includes("-w")) { | |||
| let webSocketHost = "localhost"; | |||
| let webSocketPort = 9999; | |||
|
|
|||
| let resConfig = "rescript.json"; | |||
| let resConfigFile = path.join(cwd, resConfig); | |||
| if (!fs.existsSync(resConfigFile)) { | |||
There was a problem hiding this comment.
I've moved the piece so it doesn't run for other non-watch commands.
cknitt
approved these changes
Oct 10, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.ts/.cssfile changes in mixed codebases.gentypeconfigretrieval logic overhead, making all scripts a little bit faster.