Fix of Deprecation warning: Redis.current is deprecated and will be removed in 5.0 #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pedrofurtado could you fix the merge conflict here? |
|
@iloveitaly Conflict resolved 🤝 |
|
Could a release be cut for this? The deprecation warnings in our app are quite loud. |
|
I dont think a release here will fix the issue completely if you are using resque. The core resque library needs to be patched to remove the old use of pipelined. PRs are welcome! |
|
I'm not using Resque and the fixes in master do solve the deprecation warnings. :) It's the last gem that our app (va.gov) needs to rid our logs of these warnings! 😄 |
|
@byroot any chance you could cut a new release here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #189
It fixes a deprecation warning:
Redis.current is deprecated and will be removed in 5.0🍻