Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(server): fix ERR_SERVER_ALREADY_LISTEN issue with Node v9.0.0 #1549

Merged
merged 1 commit into from
Nov 2, 2017
Merged

test(server): fix ERR_SERVER_ALREADY_LISTEN issue with Node v9.0.0 #1549

merged 1 commit into from
Nov 2, 2017

Conversation

hekike
Copy link
Member

@hekike hekike commented Nov 2, 2017 •
edited
Loading

Pre-Submission Checklist

  • Ran the linter and tests via make prepush
  • Included comprehensive and convincing tests for changes

Node v9.0.0 doesn't allow to call server.listen() multiple times.
(It's not clear why it was necessary earlier)

See: https://nodejs.org/api/errors.html#errors_err_server_already_listen

Changes

  • remove duplicated server.listen() calls from tests

@hekike
Copy link
Member Author

hekike commented Nov 2, 2017

It won't pass on TravisCI because of the IPv6 issue: #1545

I tested it on my local machine.

@hekike hekike mentioned this pull request Nov 2, 2017
Merged
@hekike hekike merged commit 92b8c53 into master Nov 2, 2017
@hekike hekike deleted the test/server-fix-ERR_SERVER_ALREADY_LISTEN branch November 2, 2017 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunong yunong yunong approved these changes

@retrohacker retrohacker Awaiting requested review from retrohacker

@DonutEspresso DonutEspresso Awaiting requested review from DonutEspresso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hekike @yunong