Skip to content
This repository has been archived by the owner on Sep 22, 2024. It is now read-only.

Fix Swagger Render On Remote #242

Merged
merged 8 commits into from
Jun 11, 2022
Merged

Fix Swagger Render On Remote #242

merged 8 commits into from
Jun 11, 2022

Conversation

alfredoihernandez
Copy link
Contributor

@alfredoihernandez alfredoihernandez commented Jun 8, 2022 •
edited
Loading

Type of PR

  • Documentation changes
  • Code changes
  • Test changes
  • CI-CD changes
  • GitHub Template changes

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Purpose of PR

Fix loading of swagger on dev endpoint. Ensure local swagger and remote UI continues to work. After this PR most remote endpoint calls on dev will be prefixed with /api/api

Does this introduce a breaking change

  • YES
  • NO

Validation

  • Unit tests updated and ran successfully
  • Update documentation or issue referenced above

Issues Closed or Referenced

@alfredoihernandez alfredoihernandez self-assigned this Jun 8, 2022
@alfredoihernandez alfredoihernandez marked this pull request as draft June 8, 2022 18:12
@alfredoihernandez alfredoihernandez marked this pull request as ready for review June 10, 2022 19:05
kforeverisback
kforeverisback approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@kforeverisback kforeverisback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in a local k3d cluster.

Swagger URL prefix changes look good.

@kforeverisback
Copy link
Contributor

Can you sync with @joaquinrz to make sure autogitops yaml changes here is sufficient to for our dev clusters?

@alfredoihernandez alfredoihernandez merged commit f6a2247 into main Jun 11, 2022
@alfredoihernandez alfredoihernandez deleted the alfredoihernandez/fix-swagger-render-on-remote branch June 11, 2022 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kforeverisback kforeverisback kforeverisback approved these changes

@joheec joheec Awaiting requested review from joheec

@joaquinrz joaquinrz Awaiting requested review from joaquinrz

Assignees

@alfredoihernandez alfredoihernandez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alfredoihernandez @kforeverisback