Skip to content
This repository has been archived by the owner on Sep 22, 2024. It is now read-only.

Move Cosmos Emulator setup to onCreate for Prebuild #262

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

joaquinrz
Copy link
Collaborator

Type of PR

  • Documentation changes
  • Code changes
  • Test changes
  • CI-CD changes
  • GitHub Template changes

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Purpose of PR

To move the cosmos emulator create script to onCreate to enable Codespaces prebuild

Does this introduce a breaking change

  • YES
  • NO

Validation

  • Unit tests updated and ran successfully
  • Update documentation or issue referenced above

Issues Closed or Referenced

@joaquinrz joaquinrz self-assigned this Jun 28, 2022
@joaquinrz joaquinrz added size: S < 2 days LoadGen WCNP Theme labels Jun 28, 2022
Copy link
Contributor

@kforeverisback kforeverisback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested.
Works when first created and works after resuming.
Cosmos emulator working as expected.

@joaquinrz joaquinrz merged commit 80ffa66 into main Jun 28, 2022
@joaquinrz joaquinrz deleted the joaquin-prebuild branch June 28, 2022 19:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
LoadGen WCNP Theme size: S < 2 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants