This repository has been archived by the owner on Sep 22, 2024. It is now read-only.
Fix incorrect error message when missing secrets. #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 2, 2022 13:29
…ilized, instead secrets are CopyToOutputDirectory when LR.API is compiled
…are in place, refactored common used code.
gortegaMS
requested review from
jofultz,
kforeverisback,
sivamu,
TravisFallsMSFT and
joaquinrz
jofultz
suggested changes
Aug 4, 2022
added 5 commits
August 5, 2022 10:32
…ecrets are missing
added 3 commits
August 5, 2022 15:20
…tanceWhenSecretsAreMissing
jofultz
approved these changes
Aug 24, 2022
gortegaMS
deleted the
gortegaMS_issue929_missing_secrets_incorrect_error_message
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
PR Checklist
Purpose of PR
Fix incorrect error message when missing secrets. The generated error message is misleading and definitely not accurate, that might cause new and existing team members to spend extra time debugging code.
Does this introduce a breaking change
Validation
Issues Closed