Skip to content
This repository has been archived by the owner on Sep 22, 2024. It is now read-only.

LodeRunner & LodeRunner.API App Declaration #294

Merged
merged 3 commits into from
Aug 9, 2022
Merged

LodeRunner & LodeRunner.API App Declaration #294

merged 3 commits into from
Aug 9, 2022

Conversation

rcaseymsft
Copy link
Contributor

@rcaseymsft rcaseymsft commented Aug 5, 2022 •
edited by kforeverisback
Loading

Type of PR

  • Documentation changes
  • Code changes
  • Test changes
  • CI-CD changes
  • GitHub Template changes

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Purpose of PR

Does this introduce a breaking change

  • YES
  • NO

Validation

  • Unit tests updated and ran successfully
  • Update documentation or issue referenced above

Issues Closed or Referenced

@rcaseymsft rcaseymsft added this to the M5 milestone Aug 5, 2022
@rcaseymsft rcaseymsft self-assigned this Aug 5, 2022
@rcaseymsft rcaseymsft changed the title Rcaseymsft/app declaration LodeRunner & LodeRunner.API App Declaration Aug 8, 2022
kforeverisback
kforeverisback approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@kforeverisback kforeverisback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@rcaseymsft rcaseymsft merged commit 2440fbc into main Aug 9, 2022
@rcaseymsft rcaseymsft deleted the rcaseymsft/app-declaration branch August 9, 2022 16:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kforeverisback kforeverisback kforeverisback approved these changes

@jofultz jofultz Awaiting requested review from jofultz

@AAkindele AAkindele Awaiting requested review from AAkindele

@PurpleBriar PurpleBriar Awaiting requested review from PurpleBriar

@alfredoihernandez alfredoihernandez Awaiting requested review from alfredoihernandez

@gortegaMS gortegaMS Awaiting requested review from gortegaMS

Assignees

@rcaseymsft rcaseymsft

Labels
None yet
Projects
None yet
Milestone
M5
Development

Successfully merging this pull request may close these issues.
2 participants
@rcaseymsft @kforeverisback