Skip to content
This repository has been archived by the owner on Sep 22, 2024. It is now read-only.

Remove "acs-report-enable" action input from vulnerability scan action as it is no longer an allowed action input #313

Merged
merged 7 commits into from
Nov 8, 2022

Conversation

gortegaMS
Copy link
Contributor

Type of PR

  • Documentation changes
  • Code changes
  • Test changes
  • CI-CD changes
  • GitHub Template changes

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Purpose of PR

Does this introduce a breaking change

  • YES
  • NO

Validation

  • Unit tests updated and ran successfully
  • Update documentation or issue referenced above

Issues Closed or Referenced

@gortegaMS gortegaMS added Bug Something isn't working CI/CD EE Fundamentals: CI/CD build/improvements LodeRunner WCNP Epic labels Nov 4, 2022
@gortegaMS gortegaMS added this to the M5 milestone Nov 4, 2022
@gortegaMS gortegaMS self-assigned this Nov 4, 2022
@gortegaMS
Copy link
Contributor Author

@microsoft-github-policy-service agree [company="Microsoft"]

@gortegaMS
Copy link
Contributor Author

@gortegaMS please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@pragmatical
Copy link
Contributor

pragmatical commented Nov 7, 2022

@gortegaMS , I have updated description of issue and PR to clarify issue that was being observed and what was done to correct it.

@pragmatical pragmatical changed the title Fix Grype definition to update "acs-report-enable" to use new allowed values Remove "acs-report-enable" action input from vulnerability scan action as it is no longer an allowed action input Nov 7, 2022
@gortegaMS gortegaMS merged commit 042b1e9 into main Nov 8, 2022
@gortegaMS gortegaMS deleted the gortegaMS-issue324-GrypeArgumentUpdate branch November 8, 2022 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working CI/CD EE Fundamentals: CI/CD build/improvements LodeRunner WCNP Epic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LodeRunner warning 'acs-report-enable' is no longer an allowed action input
3 participants