Skip to content
This repository has been archived by the owner on Sep 22, 2024. It is now read-only.

removing todo TODO: Replace notnull constraint with a non-nullable en… #316

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

pragmatical
Copy link
Contributor

…tity constraint., as not sure what the driver is or what it is attempting to accomplish

Type of PR

  • Documentation changes
  • Code changes
  • Test changes
  • CI-CD changes
  • GitHub Template changes

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Purpose of PR

Removed TODO, request does not make sense in the context and current implementation appears to accomplish what is desired

Does this introduce a breaking change

  • YES
  • NO

Validation

  • Unit tests updated and ran successfully
  • Update documentation or issue referenced above

Issues Closed or Referenced

  • Closes #1066 (this will automatically close the issue when the PR closes)

…tity constraint., as not sure what the driver is or what it is attempting to accomplish
Copy link
Contributor

@gortegaMS gortegaMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pragmatical pragmatical merged commit 48d1057 into main Nov 11, 2022
@pragmatical pragmatical deleted the pragmatical/removetodo branch November 11, 2022 16:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants